Skip to content

Commit

Permalink
only initializing maptask if there is no failure (flyteorg#352)
Browse files Browse the repository at this point in the history
Signed-off-by: Daniel Rammer <[email protected]>
  • Loading branch information
hamersaw authored May 24, 2023
1 parent 7bb490f commit 8a2f8ca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion go/tasks/plugins/array/k8s/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (e Executor) Handle(ctx context.Context, tCtx core.TaskExecutionContext) (c
nextState, err = array.DetermineDiscoverability(ctx, tCtx, pluginConfig.MaxArrayJobSize, pluginState)

nextPhase, _ := nextState.GetPhase()
if err == nil && nextPhase != arrayCore.PhaseStart {
if err == nil && nextPhase != arrayCore.PhaseStart && nextPhase != arrayCore.PhasePermanentFailure {
// we wait to transition out of PhaseStart to InitializeExternalResources because then the array
// job configuration has then been validated and all of the metadata necessary to report subtask
// status (ie. cache hit / etc) is available.
Expand Down

0 comments on commit 8a2f8ca

Please sign in to comment.