Fix getAllExample (flyteorg#320)

Signed-off-by: Eduardo Apolinario <[email protected]> Co-authored-by: Eduardo Apolinario <[email protected]>
eapolinario · May 5, 2022 · 848239e · 848239e
1 parent 779ced9
commit 848239e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/register/register_util.go b/cmd/register/register_util.go
@@ -656,7 +656,7 @@ func filterExampleFromRelease(releases *github.RepositoryRelease) []*github.Rele
 
 func getAllExample(repository, version string, repoService g.GHRepoService) ([]*github.ReleaseAsset, *github.RepositoryRelease, error) {
 	if len(version) > 0 {
-		release, err := g.GetReleaseByTag(version, repository, repoService)
+		release, err := g.GetReleaseByTag(repository, version, repoService)
 		if err != nil {
 			return nil, nil, err
 		}

diff --git a/cmd/register/register_util_test.go b/cmd/register/register_util_test.go
@@ -458,7 +458,7 @@ func TestGetAllFlytesnacksExample(t *testing.T) {
 		mockGh := &ghMocks.GHRepoService{}
 		tag := "v0.15.0"
 		sandboxManifest := "flyte_sandbox_manifest.tgz"
-		mockGh.OnGetReleaseByTagMatch(mock.Anything, mock.Anything, mock.Anything, mock.Anything).Return(&github.RepositoryRelease{
+		mockGh.OnGetReleaseByTagMatch(mock.Anything, mock.Anything, mock.Anything, tag).Return(&github.RepositoryRelease{
 			TagName: &tag,
 			Assets: []*github.ReleaseAsset{{
 				Name: &sandboxManifest,