forked from flyteorg/flyte
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Call Cache.DeleteDelayed if the item phase is terminal (flyteorg#212)
* Call Cache.DeleteDelayed if the item in the cache no longer needs to be monitored Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update to released deps Signed-off-by: Haytham Abuelfutuh <[email protected]> * PR Comments Signed-off-by: Haytham Abuelfutuh <[email protected]> * update stdlib Signed-off-by: Haytham Abuelfutuh <[email protected]> * Fix unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * Add docs to unit test Signed-off-by: Haytham Abuelfutuh <[email protected]>
- Loading branch information
Showing
5 changed files
with
95 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80 changes: 80 additions & 0 deletions
80
flyteplugins/go/tasks/pluginmachinery/internal/webapi/monitor_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| package webapi | ||
|
|
||
| import ( | ||
| "context" | ||
| "sync" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/flyteorg/flytestdlib/cache" | ||
| "github.com/flyteorg/flytestdlib/promutils" | ||
| "k8s.io/apimachinery/pkg/util/rand" | ||
| "k8s.io/client-go/util/workqueue" | ||
|
|
||
| core2 "github.com/flyteorg/flyteplugins/go/tasks/pluginmachinery/core" | ||
|
|
||
| "github.com/stretchr/testify/mock" | ||
|
|
||
| "github.com/flyteorg/flyteidl/gen/pb-go/flyteidl/core" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
|
|
||
| "github.com/flyteorg/flyteplugins/go/tasks/pluginmachinery/core/mocks" | ||
| internalMocks "github.com/flyteorg/flyteplugins/go/tasks/pluginmachinery/internal/webapi/mocks" | ||
| ) | ||
|
|
||
| func Test_monitor(t *testing.T) { | ||
| ctx := context.Background() | ||
| tCtx := &mocks.TaskExecutionContext{} | ||
| ctxMeta := &mocks.TaskExecutionMetadata{} | ||
| execID := &mocks.TaskExecutionID{} | ||
| execID.OnGetGeneratedName().Return("generated_name") | ||
| execID.OnGetID().Return(core.TaskExecutionIdentifier{}) | ||
| ctxMeta.OnGetTaskExecutionID().Return(execID) | ||
| tCtx.OnTaskExecutionMetadata().Return(ctxMeta) | ||
|
|
||
| client := &internalMocks.Client{} | ||
| client.OnStatusMatch(ctx, mock.Anything).Return(core2.PhaseInfoSuccess(nil), nil) | ||
|
|
||
| wg := sync.WaitGroup{} | ||
| wg.Add(4) | ||
| cacheObj, err := cache.NewAutoRefreshCache(rand.String(5), func(ctx context.Context, batch cache.Batch) (updatedBatch []cache.ItemSyncResponse, err error) { | ||
| wg.Done() | ||
| t.Logf("Syncing Item [%+v]", batch[0]) | ||
| return []cache.ItemSyncResponse{ | ||
| { | ||
| ID: batch[0].GetID(), | ||
| Item: batch[0].GetItem(), | ||
| Action: cache.Update, | ||
| }, | ||
| }, nil | ||
| }, workqueue.DefaultControllerRateLimiter(), time.Second, 1, 10, promutils.NewTestScope()) | ||
| assert.NoError(t, err) | ||
|
|
||
| assert.NoError(t, cacheObj.Start(ctx)) | ||
|
|
||
| // Insert a dummy item to make sure the sync loop keeps getting invoked | ||
| _, err = cacheObj.GetOrCreate("generated_name2", CacheItem{Resource: "fake_resource2"}) | ||
| assert.NoError(t, err) | ||
|
|
||
| _, err = cacheObj.GetOrCreate("generated_name", CacheItem{Resource: "fake_resource"}) | ||
| assert.NoError(t, err) | ||
|
|
||
| s := &State{} | ||
| newState, phaseInfo, err := monitor(ctx, tCtx, client, cacheObj, s) | ||
| assert.NoError(t, err) | ||
| assert.NotNil(t, newState) | ||
| assert.NotNil(t, phaseInfo) | ||
| assert.Equal(t, core2.PhaseSuccess.String(), phaseInfo.Phase().String()) | ||
|
|
||
| // Make sure the item is still in the cache as is... | ||
| cachedItem, err := cacheObj.GetOrCreate("generated_name", CacheItem{Resource: "shouldnt_insert"}) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "fake_resource", cachedItem.(CacheItem).Resource.(string)) | ||
|
|
||
| // Wait for sync to run to actually delete the resource | ||
| wg.Wait() | ||
| cachedItem, err = cacheObj.GetOrCreate("generated_name", CacheItem{Resource: "new_resource"}) | ||
| assert.NoError(t, err) | ||
| assert.Equal(t, "new_resource", cachedItem.(CacheItem).Resource.(string)) | ||
| } |