Fix invalid Kubernetes pod names (flyteorg#325)

Signed-off-by: Sean Lin <[email protected]>
eapolinario · Oct 21, 2021 · 486632d · 486632d
1 parent bd32547
commit 486632d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go b/flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager.go
@@ -7,6 +7,8 @@ import (
 	"strings"
 	"time"
 
+	"k8s.io/apimachinery/pkg/util/validation"
+
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
 	"k8s.io/apimachinery/pkg/runtime/schema"
@@ -115,6 +117,10 @@ func (e *PluginManager) AddObjectMetadata(taskCtx pluginsCore.TaskExecutionMetad
 		f := append(o.GetFinalizers(), finalizer)
 		o.SetFinalizers(f)
 	}
+
+	if errs := validation.IsDNS1123Subdomain(o.GetName()); len(errs) > 0 {
+		o.SetName(utils.ConvertToDNS1123SubdomainCompatibleString(o.GetName()))
+	}
 }
 
 func (e *PluginManager) GetProperties() pluginsCore.PluginProperties {

diff --git a/flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager_test.go b/flytepropeller/pkg/controller/nodes/task/k8s/plugin_manager_test.go
@@ -739,7 +739,7 @@ func TestPluginManager_CustomKubeClient(t *testing.T) {
 }
 
 func TestPluginManager_AddObjectMetadata(t *testing.T) {
-	genName := "genName"
+	genName := "gen-name"
 	ns := "ns"
 	or := v12.OwnerReference{}
 	l := map[string]string{"l1": "lv1"}