Skip to content

Commit

Permalink
Mark Hive and Presto query failures as Retryable to allow Propeller t…
Browse files Browse the repository at this point in the history
…o decide the behavior (flyteorg#91)

* Mark Hive Query Failures as retryable

* Mark Presto Query Failures as retryable
  • Loading branch information
EngHabu authored May 19, 2020
1 parent dc1ce43 commit 45e2087
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion go/tasks/plugins/hive/execution_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func MapExecutionStateToPhaseInfo(state ExecutionState, quboleClient client.Qubo
phaseInfo = core.PhaseInfoSuccess(ConstructTaskInfo(state))

case PhaseQueryFailed:
phaseInfo = core.PhaseInfoFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state))
phaseInfo = core.PhaseInfoRetryableFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state))
}

return phaseInfo
Expand Down
2 changes: 1 addition & 1 deletion go/tasks/plugins/presto/execution_state.go
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,7 @@ func MapExecutionStateToPhaseInfo(state ExecutionState) core.PhaseInfo {
phaseInfo = core.PhaseInfoSuccess(ConstructTaskInfo(state))
}
case PhaseQueryFailed:
phaseInfo = core.PhaseInfoFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state))
phaseInfo = core.PhaseInfoRetryableFailure(errors.DownstreamSystemError, "Query failed", ConstructTaskInfo(state))
}

return phaseInfo
Expand Down

0 comments on commit 45e2087

Please sign in to comment.