Fixed nil panic on gate node sleep check (flyteorg#507)

* fixed nil panic on gate node sleep check Signed-off-by: Dan Rammer <[email protected]> * lint issue Signed-off-by: Dan Rammer <[email protected]> Signed-off-by: Dan Rammer <[email protected]>
eapolinario · Dec 13, 2022 · 3af5184 · 3af5184
1 parent 6242e63
commit 3af5184
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/flytepropeller/pkg/controller/nodes/gate/handler.go b/flytepropeller/pkg/controller/nodes/gate/handler.go
@@ -185,8 +185,8 @@ func (g *gateNodeHandler) Handle(ctx context.Context, nCtx handler.NodeExecution
 		sleepDuration := sleepCondition.GetDuration().AsDuration()
 
 		// check duration of node sleep
-		now := time.Now()
-		if sleepDuration <= now.Sub(nCtx.NodeStatus().GetLastAttemptStartedAt().Time) {
+		lastAttemptStartedAt := nCtx.NodeStatus().GetLastAttemptStartedAt()
+		if lastAttemptStartedAt != nil && sleepDuration <= time.Since(lastAttemptStartedAt.Time) {
 			return handler.DoTransition(handler.TransitionTypeEphemeral, handler.PhaseInfoSuccess(&handler.ExecutionInfo{})), nil
 		}
 	default: