Create a separate stow Location for signed url (flyteorg#125)

* Create a separate stow Location for signed url Signed-off-by: Haytham Abuelfutuh <[email protected]> * Generate Signed-off-by: Haytham Abuelfutuh <[email protected]> * Revert ConnectionConfig deprecation for now Signed-off-by: Haytham Abuelfutuh <[email protected]> * updates Signed-off-by: Haytham Abuelfutuh <[email protected]> * Update golden test files Signed-off-by: Haytham Abuelfutuh <[email protected]> * fix unit test Signed-off-by: Haytham Abuelfutuh <[email protected]> * lint Signed-off-by: Haytham Abuelfutuh <[email protected]>
eapolinario · Apr 6, 2022 · 391dd7d · 391dd7d
1 parent e88f364
commit 391dd7d
Show file tree

Hide file tree

Showing 10 changed files with 139 additions and 55 deletions.
diff --git a/flytestdlib/cli/pflags/api/generator_test.go b/flytestdlib/cli/pflags/api/generator_test.go
@@ -3,7 +3,6 @@ package api
 import (
 	"context"
 	"flag"
-	"fmt"
 	"go/token"
 	"go/types"
 	"io/ioutil"
@@ -174,8 +173,8 @@ func TestBuildFieldForMap(t *testing.T) {
 		defaultValue := ""
 		fieldInfo, err := buildFieldForMap(ctx, typesMap, name, goName, usage, defaultValue, false)
 		assert.NotNil(t, err)
-		assert.Equal(t, fmt.Errorf("map of type [interface{/* incomplete */}] is not supported."+
-			" Only basic slices or slices of json-unmarshalable types are supported"), err)
+		assert.Contains(t, err.Error(), "is not supported."+
+			" Only basic slices or slices of json-unmarshalable types are supported")
 		assert.NotNil(t, fieldInfo)
 		assert.Equal(t, "", fieldInfo.FlagMethodName)
 		assert.Equal(t, "", fieldInfo.DefaultValue)

diff --git a/flytestdlib/cli/pflags/api/testdata/testtype.go b/flytestdlib/cli/pflags/api/testdata/testtype.go
diff --git a/flytestdlib/cli/pflags/api/testdata/testtype_bind.go b/flytestdlib/cli/pflags/api/testdata/testtype_bind.go
diff --git a/flytestdlib/go.mod b/flytestdlib/go.mod
@@ -25,7 +25,7 @@ require (
 	github.com/spf13/viper v1.7.1
 	github.com/stretchr/testify v1.7.0
 	golang.org/x/time v0.0.0-20201208040808-7e3f01d25324
-	golang.org/x/tools v0.1.0
+	golang.org/x/tools v0.1.10
 	google.golang.org/protobuf v1.25.0
 	gorm.io/gorm v1.22.4
 	k8s.io/api v0.20.2
@@ -79,12 +79,12 @@ require (
 	github.com/stretchr/objx v0.3.0 // indirect
 	github.com/subosito/gotenv v1.2.0 // indirect
 	go.opencensus.io v0.22.6 // indirect
-	golang.org/x/crypto v0.0.0-20201221181555-eec23a3978ad // indirect
+	golang.org/x/crypto v0.0.0-20210921155107-089bfa567519 // indirect
 	golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5 // indirect
-	golang.org/x/mod v0.4.1 // indirect
-	golang.org/x/net v0.0.0-20210805182204-aaa1db679c0d // indirect
+	golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect
+	golang.org/x/net v0.0.0-20211015210444-4f30a5c0130f // indirect
 	golang.org/x/oauth2 v0.0.0-20210126194326-f9ce19ea3013 // indirect
-	golang.org/x/sys v0.0.0-20210423082822-04245dca01da // indirect
+	golang.org/x/sys v0.0.0-20211019181941-9d821ace8654 // indirect
 	golang.org/x/text v0.3.7 // indirect
 	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
 	google.golang.org/api v0.38.0 // indirect