Adding support for ArrayNode (flyteorg#406)

* hydrating arraynode subnode Signed-off-by: Daniel Rammer <[email protected]> * updating flyteidl Signed-off-by: Daniel Rammer <[email protected]> * added unit tests Signed-off-by: Daniel Rammer <[email protected]> --------- Signed-off-by: Daniel Rammer <[email protected]>
eapolinario · Jul 10, 2023 · 3590432 · 3590432
1 parent 47d6c62
commit 3590432
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 365 deletions.
diff --git a/cmd/register/register_util.go b/cmd/register/register_util.go
@@ -247,6 +247,10 @@ func hydrateNode(node *core.Node, version string, force bool) error {
 		}
 	case *core.Node_GateNode:
 		// Do nothing.
+	case *core.Node_ArrayNode:
+		if err := hydrateNode(v.ArrayNode.Node, version, force); err != nil {
+			return fmt.Errorf("failed to hydrateNode")
+		}
 	default:
 		return fmt.Errorf("unknown type %T", v)
 	}

diff --git a/cmd/register/register_util_test.go b/cmd/register/register_util_test.go
@@ -502,6 +502,33 @@ func TestHydrateNode(t *testing.T) {
 	})
 }
 
+func TestHydrateArrayNode(t *testing.T) {
+	registerFilesSetup()
+	node := &core.Node{
+		Target: &core.Node_ArrayNode{
+			ArrayNode: &core.ArrayNode{
+				Node: &core.Node{
+					Target: &core.Node_TaskNode{
+						TaskNode: &core.TaskNode{
+							Reference: &core.TaskNode_ReferenceId{
+								ReferenceId: &core.Identifier{
+									ResourceType: core.ResourceType_TASK,
+									Project:      "flytesnacks",
+									Domain:       "development",
+									Name:         "n1",
+									Version:      "v1",
+								},
+							},
+						},
+					},
+				},
+			},
+		},
+	}
+	err := hydrateNode(node, rconfig.DefaultFilesConfig.Version, true)
+	assert.Nil(t, err)
+}
+
 func TestHydrateGateNode(t *testing.T) {
 	t.Run("Hydrate Sleep", func(t *testing.T) {
 		registerFilesSetup()

diff --git a/go.mod b/go.mod
@@ -9,7 +9,7 @@ require (
 	github.com/docker/docker v20.10.7+incompatible
 	github.com/docker/go-connections v0.4.0
 	github.com/enescakir/emoji v1.0.0
-	github.com/flyteorg/flyteidl v1.5.10
+	github.com/flyteorg/flyteidl v1.5.12
 	github.com/flyteorg/flytepropeller v1.1.1
 	github.com/flyteorg/flytestdlib v1.0.13
 	github.com/go-ozzo/ozzo-validation/v4 v4.3.0