[WIP] Bring graphene v3 compatibility #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabienheureux
changed the title
This was referenced Aug 6, 2020
|
@eamigo86 do you think you could give me a hand on this one ? |
fabienheureux
commented
Aug 7, 2020
fabienheureux
force-pushed
the
feature/graphene-v3-compatibility
branch
from
7fa065c to
492cf54
Compare
fabienheureux
commented
Aug 7, 2020
|
|
||
| @classmethod | ||
| def save(cls, serialized_obj, root, info, **kwargs): | ||
| """ |
There was a problem hiding this comment.
I honestly don't know why the whole file was rewritten. I tried both in vim and vscode, and in both the diff showed a full rewrite.
Interesting part below, explained in the comment.
Maybe there is a better place to check for Enum in values @eamigo86 ?
fabienheureux
force-pushed
the
feature/graphene-v3-compatibility
branch
from
492cf54 to
4bf606a
Compare
|
@ldynia @MAndersenNano are you the new maintainers of this project ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few updates in order to bring basic graphene v3 compatibility.
This obviously need a bit of review / testing.
Related graphql-python/graphene-django#705
The tests are currently broken, I guess because directives are broken as well. They use promises, for which support has been dropped in graphql core v3.