Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a version which is compatible with eXist-db 4.2.0+ #14

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

adamretter
Copy link
Contributor

@adamretter adamretter commented Dec 28, 2022

Whilst semver.xq previously demands eXist-db 5.1.0 or higher, it can actually happily execute on eXist-db 4.x.x as well. This PR adds support (and CI tests) for eXist-db 4.x.x alongside 5.x.x.

By default semver.xq will now build for a minimum version of eXist-db 4.2.0.


Note This PR should be merged before #13

@adamretter adamretter requested a review from joewiz December 28, 2022 07:16
@adamretter adamretter added the enhancement New feature or request label Dec 28, 2022
@adamretter adamretter force-pushed the existdb-4-compatibility branch from d62ff53 to 88786f4 Compare December 28, 2022 07:19
@joewiz
Copy link
Member

joewiz commented Dec 28, 2022

@adamretter Somehow in my merging of #11 and #12, a conflict has emerged with this branch. Could you please take a look at it and update the PR? Thanks!

@adamretter adamretter force-pushed the existdb-4-compatibility branch from 88786f4 to 1cb1ce7 Compare December 28, 2022 17:16
@adamretter
Copy link
Contributor Author

adamretter commented Dec 28, 2022

@joewiz Sure, no problem. I have now rebased it as requested...

@joewiz
Copy link
Member

joewiz commented Dec 28, 2022

@adamretter Does this need a rebase now that #17 has been merged? (I ask because Dependabot still shows a failure on this PR.)

@adamretter adamretter force-pushed the existdb-4-compatibility branch from 1cb1ce7 to ab6cc67 Compare December 28, 2022 19:06
@adamretter
Copy link
Contributor Author

Does this need a rebase now that #17 has been merged? (I ask because Dependabot still shows a failure on this PR.)

@joewiz Exactly! I have now rebased it again...

@joewiz joewiz merged commit 6ba464b into master Dec 28, 2022
@joewiz joewiz deleted the existdb-4-compatibility branch December 28, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants