Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyterlab-lsp for linting #63

Closed
wants to merge 7 commits into from
Closed

Use jupyterlab-lsp for linting #63

wants to merge 7 commits into from

Conversation

sverhoeven
Copy link
Member

Should be merged after #55

@sverhoeven
Copy link
Member Author

Uses default lint rules now.

This lab extension (https://github.com/krassowski/jupyterlab-lsp) also changes auto complete behavior which might not be wanted.

@SarahAlidoost
Copy link
Member

SarahAlidoost commented Jul 30, 2020

with this extension, auto-complete and tool-tips appear very slow. (also see this issue).

@sverhoeven
Copy link
Member Author

Closing for a better solution

@sverhoeven sverhoeven closed this Aug 3, 2020
@SarahAlidoost
Copy link
Member

As discussed, We add this extension for now and consider its improvements in the future. So, this PR is reopened.

@SarahAlidoost SarahAlidoost reopened this Aug 4, 2020
@SarahAlidoost
Copy link
Member

This PR is blocked by issue #66.

@sverhoeven
Copy link
Member Author

Outdated

@sverhoeven sverhoeven closed this Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants