Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #160

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Small fixes #160

merged 6 commits into from
Dec 12, 2023

Conversation

BSchilperoort
Copy link
Member

@BSchilperoort BSchilperoort commented Dec 12, 2023

Closes #158, #156

Support for Python 3.7 has been removed. Added Python 3.11 support. Python 3.12 is not possible (yet) as cdsapi supports max. 3.11.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #160 (ace3f99) into main (521ec3c) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #160   +/-   ##
=======================================
  Coverage   99.66%   99.66%           
=======================================
  Files          14       14           
  Lines         601      601           
=======================================
  Hits          599      599           
  Misses          2        2           

Copy link

@geek-yang geek-yang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the fixes.

@geek-yang
Copy link

Since the support for py3.7 is dropped, let's also remove the py3.7 thingy in pyproject.toml

"Programming Language :: Python :: 3.7",

and
target-version = ['py37', 'py38', 'py39', 'py310']

@BSchilperoort
Copy link
Member Author

Since the support for py3.7 is dropped, let's also remove the py3.7 thingy in pyproject.toml

"Programming Language :: Python :: 3.7",

and

target-version = ['py37', 'py38', 'py39', 'py310']

Thanks for noticing that!

@BSchilperoort BSchilperoort merged commit f211c70 into main Dec 12, 2023
9 checks passed
@BSchilperoort BSchilperoort deleted the small-fixes branch December 12, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small typo
2 participants