Add check for file existence #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
=======================================
Coverage 99.65% 99.66%
=======================================
Files 14 14
Lines 579 592 +13
=======================================
+ Hits 577 590 +13
Misses 2 2 |
BSchilperoort
changed the title
Peter9192
approved these changes
Apr 4, 2023
| if answer.lower() in ["n", "no", "nope"]: | ||
| raise FileExistsError( | ||
| "\n One or more files already exist in this folder." | ||
| "\n Please remove them, or change to a different folder to continue" |
There was a problem hiding this comment.
This begs for a skip-existing flag...
There was a problem hiding this comment.
I have implemented --overwrite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple check for if any of the filenames that will be created already exist. The user will be prompted if they do, and will be asked if they want to overwrite the files or not.
If they do not want to overwrite the files, a FileExistsError is thrown.
Closes #49, #76
Issue #49 mentions checking the file size, but this is not trivial, and would probably be more complex than is required here.
Additionally, I noticed that the config existence checker was not being run when making an era5cli request. I added this in and fixed the tests.