-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21696] Fix Secure Discovery Server client disposals guid and handshake_handle assertion #5257
base: 2.14.x
Are you sure you want to change the base?
Conversation
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
if (getRTPSParticipant()->is_secure()) | ||
{ | ||
// Need the mangled guid prefix in this case | ||
srv_guid_prefix = get_participant_proxy_data(svr.guidPrefix)->m_guid.guidPrefix; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the CI results, it looks like this should be used with security guards.
set_property(TEST SecureDiscoverServerMultipleClientsDisposalsReceived APPEND PROPERTY ENVIRONMENT | ||
"PATH=$<TARGET_FILE_DIR:${PROJECT_NAME}>\\;$<TARGET_FILE_DIR:fastcdr>\\;${WIN_PATH}") | ||
endif() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix EOF
|
||
if __name__ == '__main__': | ||
|
||
# Parse arguments | ||
args = ParseOptions() | ||
|
||
run(args.args) | ||
run(args.args) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EOF
Signed-off-by: Mario Dominguez <[email protected]>
Description
This PR addresses two issues regarding
Secure Discovery Server
guid
was not beaing properly send from clients to server.SecurityManager
as a consequence of not being able to retrieve a new change in theparticipant_stateless_msg_writer
@Mergifyio backport 2.10.x
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist