Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21706] Remove unused validMatching methods in EDP #5245

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 19, 2024

Description

This PR removes the validMatching deprecated methods in EDP

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/AAny new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added the no-test Skip CI tests if PR marked with this label label Sep 19, 2024
@Mario-DL Mario-DL added this to the v3.0.2 milestone Sep 19, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 19, 2024
@richiware richiware self-requested a review September 19, 2024 09:33
@richiware richiware removed the request for review from richiprosima September 20, 2024 05:40
@richiware richiware merged commit 6e86a4b into master Sep 20, 2024
15 of 25 checks passed
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Sep 20, 2024
@richiware richiware deleted the bugfix/remove-unused-methods branch September 20, 2024 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-test Skip CI tests if PR marked with this label ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants