-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21424] Add test for support of enumeration literal @value
annotation
#5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
richiware
changed the title
Add test for support of enumeration literal
[21424] Add test for support of enumeration literal Jul 26, 2024
@value
annotation@value
annotation
richiware
force-pushed
the
bugfix/21379
branch
from
September 9, 2024 10:46
8baf9e1
to
9850955
Compare
richiware
force-pushed
the
bugfix/21379
branch
from
September 25, 2024 07:48
9850955
to
0da7f56
Compare
richiware
requested review from
MiguelCompany
and removed request for
MiguelCompany
September 26, 2024 08:49
MiguelCompany
requested changes
Sep 26, 2024
src/cpp/fastdds/xtypes/type_representation/TypeObjectRegistry.cpp
Outdated
Show resolved
Hide resolved
richiware
force-pushed
the
bugfix/21379
branch
from
September 26, 2024 10:17
28e8a02
to
9ce171d
Compare
MiguelCompany
approved these changes
Sep 26, 2024
MiguelCompany
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
7 tasks
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
force-pushed
the
bugfix/21379
branch
from
September 30, 2024 06:37
9ce171d
to
844de97
Compare
MiguelCompany
approved these changes
Sep 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
MiguelCompany
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
needs-review
PR that is ready to be reviewed
labels
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-pending
PR which CI is running
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new test for new enumeration in
dds-types-test
repository.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist