Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error sending multicast on Windows in some scenarios. [4542] #394

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

richiware
Copy link
Member

@richiware richiware commented Jan 30, 2019

This solves an issue when sending multicast on Windows machines with more than one interface where some of them are disconnected. In that case, the default multicast route may not be the first one.

This PR may fix ros2/rmw_fastrtps#246

@richiware richiware changed the title Fixed error sending multicast on Windows in only one interface. Fixed error sending multicast on Windows in only one interface. [4542] Jan 30, 2019
@eProsima eProsima deleted a comment from richiware Jan 31, 2019
@MiguelCompany MiguelCompany changed the title Fixed error sending multicast on Windows in only one interface. [4542] Fixed error sending multicast on Windows in some scenarios. [4542] Jan 31, 2019
@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit d2ec94e into release/1.7.1 Jan 31, 2019
@richiware richiware deleted the hotfix/windows_multicast branch January 31, 2019 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants