Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sanitizer warning message if option not set #3060

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Avoid sanitizer warning message if option not set #3060

merged 1 commit into from
Nov 4, 2022

Conversation

rsanchez15
Copy link
Contributor

@rsanchez15 rsanchez15 commented Nov 3, 2022 •
edited
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added.
  • Any new/modified methods have been properly documented using Doxygen.
  • Fast DDS test suite has been run locally.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • Documentation builds and tests pass locally.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.

Reviewer Checklist

  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JLBuenoLopez JLBuenoLopez added no-test Skip CI tests if PR marked with this label no-aarch Skip build & test for aarch64 labels Nov 3, 2022
JLBuenoLopez
JLBuenoLopez approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@MiguelCompany MiguelCompany merged commit f6ef950 into master Nov 4, 2022
@MiguelCompany MiguelCompany deleted the hotfix/sanitizer-cmake branch November 4, 2022 06:19
@JLBuenoLopez JLBuenoLopez mentioned this pull request Nov 4, 2022
Merged
13 tasks
@clalancette clalancette mentioned this pull request Nov 4, 2022
Merged
@mjcarroll
Copy link

Confirmed that this fixes things (https://ci.ros2.org/job/ci_windows/18163/). Thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
no-aarch Skip build & test for aarch64 no-test Skip CI tests if PR marked with this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsanchez15 @mjcarroll @JLBuenoLopez @MiguelCompany