Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21795] CdrSizeCalculator adds 4 bytes extra in a fixed string member of mutable structure in XCDRv2 #238

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Oct 3, 2024

Description

It was detected that CdrSizeCalculator adds 4 bytes extra when calculating a fixed string member of a @mutable structure in XCdrv2. For example:

@mutable
struct FixedStringMember
{
    string<20> var;
};

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware added this to the v2.2.5 - Frozen ❄️ milestone Oct 3, 2024
@richiware richiware changed the title CdrSizeCalculator adds 4 bytes extra in a fixed string member of mutable structure in XCDRv2 [21795] CdrSizeCalculator adds 4 bytes extra in a fixed string member of mutable structure in XCDRv2 Oct 3, 2024
@MiguelCompany MiguelCompany self-requested a review October 4, 2024 09:10
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiware richiware merged commit 5d445ee into master Oct 4, 2024
11 checks passed
@richiware richiware deleted the bugfix/21794 branch October 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants