Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21556] Bugfix: clear map before deserializing with string as values in XCRv1 #233

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Aug 7, 2024

Description

A map<T, string> was not being cleared before deserializing in XCDRv1. Test and fix included. Thanks @fschoenm for the report and @MiguelCompany for the analysis.

@Mergifyio backport 2.2.x 1.0.x

Fixes eProsima/Fast-DDS/issues/5136

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: CI pass and failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added this to the v2.2.4 milestone Aug 7, 2024
@Mario-DL Mario-DL changed the title [21443] Bugfix: clear map before deserializing a map with string as values in XCRv1 [21443] Bugfix: clear map before deserializing with string as values in XCRv1 Aug 7, 2024
@Mario-DL Mario-DL changed the title [21443] Bugfix: clear map before deserializing with string as values in XCRv1 [21556] Bugfix: clear map before deserializing with string as values in XCRv1 Sep 4, 2024
test/cdr/SimpleTest.cpp Outdated Show resolved Hide resolved
@Mario-DL Mario-DL requested review from richiware and removed request for richiware September 6, 2024 06:34
@richiware richiware merged commit 371fba8 into master Sep 10, 2024
11 checks passed
@richiware richiware deleted the bugfix/clear-map branch September 10, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataReader::read() reads invalid data
2 participants