Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update user_table.mustache #117

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

brunobaudry
Copy link
Contributor

Fixes the broken json with languages (like French) that could use single or doulle quotes in field headers.

Should be compatible with previous version to 4.0.
Since 4.0 one could replace {{#htmlescape}}{{#str}} with {{#cleanstr}}

Cleaner way to fix the broken json with languages that could use single or doulle quotes in field headers.
@my-curiosity
Copy link
Contributor

Hi @brunobaudry,
thank you for the PR. This plugin already requires Moodle 4.0 (see version.php), so it would probably be better to use {{#cleanstr}}.

reverted to cleanstr as per PR comments
@brunobaudry
Copy link
Contributor Author

Hi @my-curiosity ,

updated

@my-curiosity my-curiosity merged commit 974f4bf into eLearning-TUDarmstadt:master Jan 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants