PE-643 Add a weekly job to sync user status and info from Entra ID #623
+238
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| // Get the day of the week to sync. Default is Saturday. | ||
| $sync_day = \Drupal::state()->get('epgov.user_sync.day_of_week') ?? "Saturday"; | ||
| if(date("l") != $sync_day) return; |
There was a problem hiding this comment.
I think the epgov.user_sync.interval_in_days setting is potentially misleading/confusing since it will only ever run on the set day of week. For example, setting the interval_in_days to 2 won't make it run every other day; it will still only run on Saturdays. So it's not clear to me how/why someone would use the interval_in_days setting.
| if( $queue != null ) $queue->deleteQueue(); | ||
|
|
||
| // Set the Day of Week to today | ||
| \Drupal::state()->set('epgov.user_sync.day_of_week', date("l")); |
There was a problem hiding this comment.
Won't this change all future user sync cron runs from Saturday to whatever day this drush command was run on>
|
|
||
| // Look up user by Drupal user name (Principal name in AD) | ||
| // Sometimes a user will be recreated with the same principal name but different AD ID | ||
| $users = \Drupal::entityTypeManager()->getStorage('user')->loadByProperties(['name' => $user_data['userPrincipalName']]); |
There was a problem hiding this comment.
Shouldn't this use the trimmed principal name in case the name was trimmed when the user was created (line 109)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.