return stable object for useModal

eBay · Sep 27, 2023 · 65dee75 · 65dee75
1 parent 7fa8bad
commit 65dee75
Showing 1 changed file with 26 additions and 12 deletions.
diff --git a/src/index.tsx b/src/index.tsx
@@ -356,18 +356,32 @@ export function useModal(modal?: any, args?: any): any {
     [mid],
   );
 
-  return {
-    id: mid,
-    args: modalInfo?.args,
-    visible: !!modalInfo?.visible,
-    keepMounted: !!modalInfo?.keepMounted,
-    show: showCallback,
-    hide: hideCallback,
-    remove: removeCallback,
-    resolve: resolveCallback,
-    reject: rejectCallback,
-    resolveHide,
-  };
+  return useMemo(
+    () => ({
+      id: mid,
+      args: modalInfo?.args,
+      visible: !!modalInfo?.visible,
+      keepMounted: !!modalInfo?.keepMounted,
+      show: showCallback,
+      hide: hideCallback,
+      remove: removeCallback,
+      resolve: resolveCallback,
+      reject: rejectCallback,
+      resolveHide,
+    }),
+    [
+      mid,
+      modalInfo?.args,
+      modalInfo?.visible,
+      modalInfo?.keepMounted,
+      showCallback,
+      hideCallback,
+      removeCallback,
+      resolveCallback,
+      rejectCallback,
+      resolveHide,
+    ],
+  );
 }
 export const create = <P extends {}>(
   Comp: React.ComponentType<P>,