Do not remove server from peer list immediately #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should not remove the server from the list immediately, due to the issue as follows: 0) Let's suppose there are 3 servers: S1, S2, and S3, where S1 is the leader and S3 is going to leave. 1) Generate a conf log for removing server S3. 2) The conf log is committed by S1 and S2 only. 3) Before delivering the conf log to S3, S1 removes the S3 peer info from the list. 4) It closes the connection to S3. 5) S3 cannot commit the config (containing removing S3). 6) Callback function for `RemovedFromCluster` will be missing, but S3 will step down itself after 2 timeout period. * To address it, we will remove S3 only after the commit index of the last config is delivered to S3. Also we will have timeout for it. If we fail to deliver the commit index, S3 will be just force removed.
greensky00
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to the issue as follows:
where S1 is the leader and S3 is going to leave.
the S3 peer info from the list.
RemovedFromClusterwill be missing,but S3 will step down itself after 2 timeout period.
of the last config is delivered to S3. Also we will have timeout
for it. If we fail to deliver the commit index, S3 will be just
force removed.