give a chance for the last obj to retry #547
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when install snapshot happens , if something off (for example, data crc mismatch)happens to the last obj, we have no chance to ask leader to resend the last obj, since
NuRaft/src/handle_snapshot_sync.cxx
Line 520 in 99eeef3
this change give a chance for follower to ask leader to resend the last obj. for example , if follower find the data crc mismatch, it can set is_last_obj to false , which means this is not the last obj the follower wants. meanwhile , follower can set obj_id to the last_obj_id, so that leader will resend the last obj to follower