Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give a chance for the last obj to retry #547

Conversation

JacksonYao287
Copy link

when install snapshot happens , if something off (for example, data crc mismatch)happens to the last obj, we have no chance to ask leader to resend the last obj, since

if (is_last_obj) {
will definitely apply_snapshot when is_last_obj is true.

this change give a chance for follower to ask leader to resend the last obj. for example , if follower find the data crc mismatch, it can set is_last_obj to false , which means this is not the last obj the follower wants. meanwhile , follower can set obj_id to the last_obj_id, so that leader will resend the last obj to follower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant