Make auto-forwarding serialized and parallel #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, I've added RPC timeouts to my fork https://github.com/ClickHouse-Extras/NuRaft/pull/5/files. If this solution looks ok then let me know and I'll create a PR. |
|
Thanks @alesapin , please go ahead and create a PR. This PR needs to be adapted a bit more for efficiency by having a request queue for async mode. |
* Added a new parameter `auto_forwarding_max_connections_`, and auto-forwarding can be parallelized up to this number. * Raft server is actively managing the RPC client so as to avoid the race on the same connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of auto_forwarding_= true, an error of "socket is already in use, race happened on connection to " appears for the append_entries of the follower #184
Added a new parameter
auto_forwarding_max_connections_, andauto-forwarding can be parallelized up to this number.
Raft server is actively managing the RPC client so as to avoid
the race on the same connection.
TODO: handling RPC timeout of auto-forwarding.