Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image to use JDK 21 #3

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Update image to use JDK 21 #3

merged 2 commits into from
Dec 11, 2024

Conversation

osipxd
Copy link
Contributor

@osipxd osipxd commented Dec 10, 2024

  • Use eclipse-temurin:21 as the base image
  • Move chrome dependencies to a separate file
  • Adapt dependencies for Ubuntu 24.04
  • Don't install node and npm, as Kotlin doesn't use then and installs them on its own

@osipxd osipxd changed the title Update image Update image to JDK 21 Dec 10, 2024
@osipxd osipxd changed the title Update image to JDK 21 Update image to use JDK 21 Dec 10, 2024
@osipxd osipxd marked this pull request as draft December 11, 2024 11:01
- Use eclipse-temurin:21 as the base image
- Move chrome dependencies to a separate file
- Adapt dependencies for Ubuntu 24.04
- Don't install node and npm
@osipxd osipxd marked this pull request as ready for review December 11, 2024 11:46
@e5l
Copy link
Owner

e5l commented Dec 11, 2024

maybe we want to use sdkman to install jdk

@e5l e5l merged commit 623915b into e5l:master Dec 11, 2024
@osipxd osipxd deleted the update-image branch December 11, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants