revert overflow-x-scroll on footer from #2054 #2151
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@LinqLover is there something we are missing here? I also need to reduce my page size to a point where the rest of the page is unusable anyway in order to get overflow on the footer. |
richardebeling
approved these changes
Mar 25, 2024
Kakadus
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Another "bug" I observed with overflow-x-scroll: When I leave the zoom at 100%, do not change the height and make the window very thin, I can somehow get the navbar to scroll horizontally for a few pixels. I think it's the "Legal Notice / Data Privacy" button. Maybe this is the symptom on linux devices? It stops if there is no overflow-x-scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2054
overflow-x-scrollwas added to the footer ("make footer horizontally scrollable on small screens; The previous behavior was the footer became wider than the screen and the entire page width was increased.")This leads to a disabled scrollbar (only visible in some browsers on some systems, depending on the scrollbar rendering) in normal resolution, which is worse :)
This PR reverts that change, but future commits are welcome. I won't open a new issue, though, because the effect only occurs on very small screens (works on my phone) and doesn't seem worth the effort.