Fix typecheck failure introduced with django-stubs==4.2.5
#2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardebeling
force-pushed
the
typing
branch
from
cbea254 to
d87ecf3
Compare
richardebeling
force-pushed
the
typing
branch
from
d87ecf3 to
d0d072c
Compare
richardebeling
commented
Oct 22, 2023
niklasmohrin
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With their 4.2.5 release (coming from 4.2.4), django-stubs did two things that broke type checking for us
"UserProfile) without an app label ("evaluation.UserProfile"works).AbstractBaseUser.REQUIRED_FIELDSas aClassVar, we had it defined as an instance variable.