Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy from ~=1.4.1 to ~=1.5.1, django-stubs from ~=4.2.0 to ~=4.2.4 #2003

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 21, 2023

Updates the requirements on mypy to permit the latest version.

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@richardebeling
Copy link
Member

Quote from #1996:

This seems to be a bug in django-stubs, so we'll just have to wait: typeddjango/django-stubs#1648

@niklasmohrin niklasmohrin marked this pull request as draft August 21, 2023 21:54
@dependabot dependabot bot force-pushed the dependabot/pip/mypy-approx-eq-1.5.1 branch from 1dd3afc to 834a0bd Compare August 28, 2023 19:21
Updates the requirements on [mypy](https://github.com/python/mypy) to permit the latest version.
- [Commits](python/mypy@v1.4.1...v1.5.1)

---
updated-dependencies:
- dependency-name: mypy
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@richardebeling richardebeling force-pushed the dependabot/pip/mypy-approx-eq-1.5.1 branch from 834a0bd to 277aa73 Compare September 5, 2023 13:54
@richardebeling richardebeling marked this pull request as ready for review September 5, 2023 13:54
@richardebeling richardebeling force-pushed the dependabot/pip/mypy-approx-eq-1.5.1 branch from 277aa73 to b39b8e8 Compare September 5, 2023 14:58
@richardebeling richardebeling changed the title Update mypy requirement from ~=1.4.1 to ~=1.5.1 Update mypy from ~=1.4.1 to ~=1.5.1, django-stubs from ~=4.2.0 to ~=4.2.4 Sep 5, 2023
Copy link
Member

@niklasmohrin niklasmohrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also switch to let django stubs dictate our mypy version using their [compatible-mypy] specifier? I think not, as I feel that we are better off getting mypy upgrade suggestions from dependabot and, if needed, waiting for django stubs to catch up if something breaks

@richardebeling
Copy link
Member

Should we also switch to let django stubs dictate our mypy version using their [compatible-mypy] specifier? I think not, as I feel that we are better off getting mypy upgrade suggestions from dependabot and, if needed, waiting for django stubs to catch up if something breaks

Sounds good to me.

@dependabot squash and merge

@dependabot dependabot bot merged commit e7766cc into main Sep 10, 2023
@dependabot dependabot bot deleted the dependabot/pip/mypy-approx-eq-1.5.1 branch September 10, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[T] Dependencies Used by Dependabot
Development

Successfully merging this pull request may close these issues.

3 participants