Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'can't give feedback' button does not clear textanswers #2302

Open
Kakadus opened this issue Oct 11, 2024 · 1 comment
Open

'can't give feedback' button does not clear textanswers #2302

Kakadus opened this issue Oct 11, 2024 · 1 comment
Labels
[C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners.

Comments

@Kakadus
Copy link
Collaborator

Kakadus commented Oct 11, 2024

To skip evaluating a contributor and select "no answer" for all its questions, the "I can't give feedback about this contributor" button can be used. If the user changes a radio input value, this button gets activated again.

After clicking this button, textanswers for that contributor are still submitted, which might be unexpected.
When the contributor only has textanswers, the button is useless and cannot be activated again after being clicked once.

Instead, all textanswers for that contributor should be cleared as well - also textanswers attached to rating questions. Also see #2302 (comment). When the user edits a textanswer, this button should be activated again.

@janno42
Copy link
Member

janno42 commented Oct 11, 2024

After clicking the button, a confirmation modal should be displayed to confirm the deletion of the text answers to avoid losing valuable data if text answers have already been entered for that contributor.

@janno42 janno42 added [C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners. labels Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Frontend Focuses on frontend implementation [P] Medium Medium priority [S] Easy This issue is self-contained and does not touch too many parts. Good choice for beginners.
Development

No branches or pull requests

2 participants