Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(utils): cache error is being rethrown #65

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

currently errors from GitHub cache will be rethrown except for reserve cache error.

Issue Number: N/A

What is the new behavior?

all cache error will be caught and warned instead

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ronnetzer ronnetzer closed this Dec 19, 2022
@ronnetzer ronnetzer reopened this Dec 19, 2022
@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #65 (f5c0dde) into main (18a7bbe) will decrease coverage by 0.32%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   87.92%   87.59%   -0.33%     
==========================================
  Files          15       15              
  Lines         381      379       -2     
  Branches       55       54       -1     
==========================================
- Hits          335      332       -3     
- Misses         43       44       +1     
  Partials        3        3              
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø)
utils 80.08% <66.66%> (-0.62%) ⬇️
Impacted Files Coverage Δ
packages/utils/src/lib/inputs.ts 57.37% <0.00%> (-0.96%) ⬇️
packages/utils/src/lib/cache.ts 98.11% <100.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ronnetzer ronnetzer merged commit 107c7d5 into main Dec 19, 2022
@ronnetzer ronnetzer deleted the fix/silent-cache-errors branch December 19, 2022 15:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant