Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(nx-affected-matrix): e2e apps are ignored #55

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

ronnetzer
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

e2e apps are being ignored from affected calculations

Issue Number: fixes #54

What is the new behavior?

e2e apps will be added to the apps array

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@nx-cloud
Copy link

nx-cloud bot commented Aug 3, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 06a9ee5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #55 (06a9ee5) into main (353e717) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #55   +/-   ##
=======================================
  Coverage   87.92%   87.92%           
=======================================
  Files          15       15           
  Lines         381      381           
  Branches       55       55           
=======================================
  Hits          335      335           
  Misses         43       43           
  Partials        3        3           
Flag Coverage Δ *Carryforward flag
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø) Carriedforward from 353e717
utils 80.70% <ø> (ø) Carriedforward from 353e717

*This pull request uses carry forward flags. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ronnetzer ronnetzer marked this pull request as ready for review August 3, 2022 11:57
@ronnetzer ronnetzer changed the title fix(nx-affected-matrix): e2e apps are ignored #54 fix(nx-affected-matrix): e2e apps are ignored Aug 3, 2022
@ronnetzer ronnetzer merged commit 5819478 into main Aug 3, 2022
@ronnetzer ronnetzer deleted the bugfix/e2e-ignored branch August 3, 2022 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

affected matrix ignores e2e target
1 participant