Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

fix(utils): support new and old custom hashers #42

Merged
merged 6 commits into from
Mar 15, 2022

Conversation

ronnetzer
Copy link
Member

@ronnetzer ronnetzer commented Mar 15, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

currently NX is having a new way of invoking custom hashers (its still experimental). the action only supports the new one which breaks the action on older nx workspaces

Issue Number: N/A

What is the new behavior?

supporting both ways by checking the amount of arguments needed for the customHasher function

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #42 (c3c0bb0) into main (9596455) will increase coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   88.12%   88.42%   +0.30%     
==========================================
  Files          15       15              
  Lines         362      363       +1     
  Branches       50       51       +1     
==========================================
+ Hits          319      321       +2     
  Misses         39       39              
+ Partials        4        3       -1     
Flag Coverage Δ
nx-affected-matrix 95.91% <ø> (ø)
nx-distributed-task 100.00% <ø> (ø)
utils 82.14% <ø> (+0.52%) ⬆️
Impacted Files Coverage Δ
packages/utils/src/lib/inputs.ts 62.50% <0.00%> (+0.68%) ⬆️
packages/utils/src/lib/cache.ts 98.21% <0.00%> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c6ef1c...c3c0bb0. Read the comment docs.

@ronnetzer ronnetzer changed the title ci: use latest actions fix(utils): support new and old custom hashers Mar 15, 2022
@ronnetzer ronnetzer marked this pull request as ready for review March 15, 2022 18:16
@ronnetzer ronnetzer merged commit 4df7758 into main Mar 15, 2022
@ronnetzer ronnetzer deleted the bugfix/cant-read-props-of-undefined branch March 26, 2022 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant