This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
feat(nx-distributed-task): reimplement caching mechanism #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
create hasher and task-graph utils deprecate distribution input remove distribution from inputs interface change cache saving to be per project target's hash
☁️ Nx Cloud ReportCI ran the following commands for commit 5d50764. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov Report
@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 86.18% 88.12% +1.93%
==========================================
Files 15 15
Lines 362 362
Branches 54 50 -4
==========================================
+ Hits 312 319 +7
+ Misses 41 39 -2
+ Partials 9 4 -5
Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: fixes #19
What is the new behavior?
caching is now performed by calculating the hash of the executing command, it will be calculated per project being passed to the action and also saved to github's cache per project's target
create hasher and task-graph utils
deprecate distribution input
remove distribution from inputs interface
change cache saving to be per project target's hash
restore task's deps in case task cache is missing
Does this PR introduce a breaking change?