Skip to content
This repository has been archived by the owner on Jul 9, 2024. It is now read-only.

feat: migrate to composite actions #27

Merged
merged 1 commit into from
Mar 1, 2022
Merged

Conversation

ronnetzer
Copy link
Member

@ronnetzer ronnetzer commented Feb 24, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines: CONTRIBUTING.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

remove git utils and use nrwl/nx-set-shas action instead
closes #21 closes #22

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 3d39a7e. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #27 (3d39a7e) into main (75aec2c) will increase coverage by 0.78%.
The diff coverage is 88.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   85.46%   86.24%   +0.78%     
==========================================
  Files          12       13       +1     
  Lines         344      349       +5     
  Branches       46       51       +5     
==========================================
+ Hits          294      301       +7     
+ Misses         40       38       -2     
  Partials       10       10              
Flag Coverage Δ
nx-affected-matrix 97.77% <100.00%> (-0.05%) ⬇️
nx-distributed-task 91.89% <93.10%> (-2.71%) ⬇️
utils 83.52% <84.82%> (+1.52%) ⬆️
Impacted Files Coverage Δ
packages/utils/src/lib/fs.ts 25.00% <40.00%> (-3.00%) ⬇️
packages/utils/src/lib/inputs.ts 65.51% <46.15%> (ø)
packages/utils/src/lib/npm.ts 66.66% <66.66%> (ø)
packages/nx-distributed-task/src/app/inputs.ts 80.00% <75.00%> (-3.34%) ⬇️
packages/utils/src/lib/exec.ts 90.62% <83.33%> (-3.13%) ⬇️
packages/utils/src/lib/nx.ts 83.92% <86.66%> (ø)
packages/utils/src/lib/logger.ts 91.66% <90.32%> (+48.80%) ⬆️
...nx-distributed-task/src/app/nx-distributed-task.ts 93.75% <96.00%> (-3.03%) ⬇️
packages/nx-affected-matrix/src/app/inputs.ts 100.00% <100.00%> (ø)
...s/nx-affected-matrix/src/app/nx-affected-matrix.ts 97.56% <100.00%> (-0.06%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d9ccf...3d39a7e. Read the comment docs.

@ronnetzer ronnetzer marked this pull request as draft February 28, 2022 14:13
@ronnetzer ronnetzer marked this pull request as ready for review February 28, 2022 19:09
@ronnetzer ronnetzer force-pushed the feature/composite-actions branch from 16e04f2 to 7f072c4 Compare March 1, 2022 07:04
remove git utils and use nrwl/nx-set-shas action instead
closes #21, closes #22
@ronnetzer ronnetzer force-pushed the feature/composite-actions branch from 7f072c4 to 3d39a7e Compare March 1, 2022 07:18
@ronnetzer ronnetzer merged commit 026026e into main Mar 1, 2022
@ronnetzer ronnetzer deleted the feature/composite-actions branch March 1, 2022 08:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Migrate to composite actions [FEAT] use Nx set SHAs github action
1 participant