feat: extract ncc builder to its own package

e-square-io · Jul 11, 2021 · cc444bd · cc444bd
1 parent 5ec945e
commit cc444bd
Show file tree

Hide file tree

Showing 13 changed files with 597 additions and 520 deletions.
diff --git a/README.md b/README.md
@@ -3,7 +3,7 @@
 [![GitHub Workflow Status](https://img.shields.io/github/workflow/status/e-square-io/nx-github-actions/Main%20Workflow?style=flat-square)](https://github.com/e-square-io/nx-github-actions/actions/workflows/main.yml)
 [![Codecov](https://img.shields.io/codecov/c/github/e-square-io/nx-github-actions?logo=codecov&style=flat-square&token=PVPVUJAD1X)](https://app.codecov.io/gh/e-square-io/nx-github-actions)
 [![PRs](https://img.shields.io/badge/PRs-welcome-brightgreen.svg?style=flat-square)](.github/PULL_REQUEST_TEMPLATE.md)
-[![All Contributors](https://img.shields.io/badge/all_contributors-0-orange.svg?style=flat-square)](#contributors-)
+[![All Contributors](https://img.shields.io/badge/all_contributors-1-orange.svg?style=flat-square)](#contributors-)
 [![styled with prettier](https://img.shields.io/badge/styled_with-prettier-ff69b4.svg?style=flat-square)](https://github.com/prettier/prettier)
 [![commitizen](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg?style=flat-square)](CONTRIBUTING.md#commit-message-format)
 [![MIT](https://img.shields.io/packagist/l/doctrine/orm.svg?style=flat-square)](LICENSE)

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -42,6 +42,7 @@
     "@commitlint/cli": "^12.1.4",
     "@commitlint/config-angular": "^12.1.4",
     "@commitlint/config-conventional": "^12.1.4",
+    "@e-square/nx-ncc": "^1.0.7",
     "@nrwl/cli": "12.5.2",
     "@nrwl/devkit": "12.5.2",
     "@nrwl/eslint-plugin-nx": "12.5.2",
@@ -55,7 +56,6 @@
     "@types/node": "14.14.33",
     "@typescript-eslint/eslint-plugin": "4.19.0",
     "@typescript-eslint/parser": "4.19.0",
-    "@vercel/ncc": "^0.28.5",
     "all-contributors-cli": "^6.19.0",
     "cross-env": "^7.0.3",
     "dotenv": "8.2.0",

diff --git a/packages/nx-affected-matrix/project.json b/packages/nx-affected-matrix/project.json
@@ -19,13 +19,20 @@
       }
     },
     "build": {
-      "executor": "./tools/executors/package:package",
+      "executor": "@e-square/nx-ncc:build",
       "outputs": ["{options.outputPath}"],
       "options": {
         "main": "packages/nx-affected-matrix/src/index.ts",
-        "actionPath": "packages/nx-affected-matrix/action.yml",
+        "tsConfig": "packages/nx-affected-matrix/tsconfig.lib.json",
         "outputPath": "dist/packages/nx-affected-matrix",
-        "assets": ["README.md"]
+        "assets": [
+          "README.md",
+          {
+            "input": "packages/nx-affected-matrix",
+            "glob": "action.yml",
+            "output": "."
+          }
+        ]
       }
     }
   },

diff --git a/packages/nx-affected-matrix/tsconfig.lib.json b/packages/nx-affected-matrix/tsconfig.lib.json
@@ -3,7 +3,6 @@
   "compilerOptions": {
     "module": "commonjs",
     "outDir": "../../dist/out-tsc",
-    "declaration": true,
     "types": ["node"]
   },
   "exclude": ["**/*.spec.ts"],

diff --git a/packages/nx-distributed-task/project.json b/packages/nx-distributed-task/project.json
@@ -19,13 +19,20 @@
       }
     },
     "build": {
-      "executor": "./tools/executors/package:package",
+      "executor": "@e-square/nx-ncc:build",
       "outputs": ["{options.outputPath}"],
       "options": {
         "main": "packages/nx-distributed-task/src/index.ts",
-        "actionPath": "packages/nx-distributed-task/action.yml",
+        "tsConfig": "packages/nx-distributed-task/tsconfig.lib.json",
         "outputPath": "dist/packages/nx-distributed-task",
-        "assets": ["README.md"]
+        "assets": [
+          "README.md",
+          {
+            "input": "packages/nx-distributed-task",
+            "glob": "action.yml",
+            "output": "."
+          }
+        ]
       }
     }
   },

diff --git a/packages/nx-distributed-task/src/lib/nx-distributed-task.ts b/packages/nx-distributed-task/src/lib/nx-distributed-task.ts
@@ -1,4 +1,4 @@
-import { endGroup, getInput, info, setFailed, setOutput, startGroup } from '@actions/core';
+import { endGroup, getInput, info, setFailed, startGroup } from '@actions/core';
 import { Inputs } from './inputs';
 import {
   assertNxInstalled,

diff --git a/packages/nx-distributed-task/tsconfig.lib.json b/packages/nx-distributed-task/tsconfig.lib.json
@@ -3,7 +3,6 @@
   "compilerOptions": {
     "module": "commonjs",
     "outDir": "../../dist/out-tsc",
-    "declaration": true,
     "types": ["node"]
   },
   "exclude": ["**/*.spec.ts"],

diff --git a/tools/executors/package/builder.json b/tools/executors/package/builder.json