Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native video player for the user manual #172

Merged
merged 12 commits into from
Sep 20, 2023
Merged

Conversation

khalifan-kfan
Copy link
Collaborator

@khalifan-kfan khalifan-kfan commented Jul 24, 2023

Description

This pull request adds a native video player for the native devices in support rather than only web

Discussion

#138

Preview

_Live link

Screenshots / Videos

_Screenshot 2023-07-24 at 13 35 38

Due to embaded screens limitations
Screenshot 2023-07-24 at 13 20 07
Refactored to
Screenshot 2023-07-24 at 15 11 08
Screenshot 2023-07-24 at 15 11 32

Copy link
Collaborator

@chrismclarke chrismclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khalifan-kfan , apologies again for the slow response to reviews

I discovered the issue with the native player, it turns out that some additional changes need to be made to android files which isn't documented very well (deep in api docs found this section: https://github.com/jepiqueau/capacitor-video-player/blob/master/docs/API.md#android-quirks). Also the path to the video needs to be prefixed by public, e.g. public/assets/videos/video.mp4, again not clearly documented.

But now everything is working I've refactored to a shared component and will make a follow-up PR to integrate with the rest of the app. Specifically

  • Refactor resources to use native video player
  • Add functionality to download video before play

Thanks for your work on this

Android demo (ignore layout slight glitch after video close, this is a bug with using emulator alongside devtools)

untitled.webm

Web Demo

Picsa.Extension.webm

@chrismclarke chrismclarke merged commit ba284fe into main Sep 20, 2023
2 checks passed
@chrismclarke chrismclarke deleted the fix/native-video-player branch September 20, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants