Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and/or replace support for time based upgrade #111

Closed
blewater opened this issue Aug 10, 2021 · 0 comments · Fixed by #107
Closed

Remove and/or replace support for time based upgrade #111

blewater opened this issue Aug 10, 2021 · 0 comments · Fixed by #107
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@blewater
Copy link
Contributor

Ref Cosmos #8538 consensus failure when upgrading by time.

Describe the solution you'd like
Before the next release, remove the default time-based upgrade mechanism.

Describe alternatives you've considered

  • Existing genesis-based
  • Opening an issue at the Tendermint team to make them aware of our dynamic block timings.
  • A custom or hybrid time scheduling scheme i.e. time + height offset e.g. 22:00 UTC + 10 height.

Additional context
If we end up implementing our own scheme, we should be aware of the chain panic upon setting the time value.

cosmos.upgrade.v1beta1.Plan#time is deprecated, because the SDK stops supporting time-based upgrades in favor or height-based upgrades. If an upgrade Plan is created with a non-empty time, the node will error.
Ref https://github.com/cosmos/cosmos-sdk/releases/tag/v0.43.0

@blewater blewater added bug Something isn't working good first issue Good for newcomers labels Aug 10, 2021
@haasted haasted added this to the Stargate milestone Aug 10, 2021
blewater added a commit that referenced this issue Aug 10, 2021
@blewater blewater linked a pull request Aug 12, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants