-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeseries query #34
Timeseries query #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlirezaRa94 LGTM except for the comment below.
Is there a reason why this is a draft?
Can you indicate the testing done, so that I can merge it as well?
I don't see any high level issues, and am happy to merge this once you have verified that it works |
I have tested the dashboard with the development docker-compose on both types of authentication and didn't see any errors on different pages. |
@AlirezaRa94 have you tested it with the use case of invalid columns? |
Yes, It works in these scenarios, and I have tried to consider them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general. @AlirezaRa94 would like to see a detailed "testing done" description and testing screenshots in the future so I know what you mean exactly by "it works in these scenarios".
Using time series queries to address #29