Support and test the reverse proxy configuration #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can test the reverse proxy configuration fixes in dev This fixes #24 (comment) The `docker-compose` (except for `nginx`) should be kept consistent with the production `docker-compose-prod.yml` with the exception of `DASH_DEBUG_MODE`, which is set to true so that we can debug errors in the setup more easily Testing done: - Built and ran the docker-compose - Accessing http://localhost:8060/admin gives the same error as #24 (comment) ``` Uncaught ReferenceError: DashRenderer is not defined <anonymous> http://localhost:8060/admin/:58 ```
This internally sets the `requests_pathname_prefix`, which allows us to load all the assets (including the javascript files) correctly. This is a partial fix for #24 that implements the first step in #24 (comment)
This fixes #24 (comment) #24 (comment) #24 (comment) Since there are not a lot of hrefs and they are all in the same file #24 (comment) ``` $ grep -r href . | grep -v .git ./utils/cognito_utils.py: dbc.Button('Login with AWS Cognito', id='login-button', href=CognitoConfig.AUTH_URL, style={ ./app_sidebar_collapsible.py: href=dash.get_relative_path("/"), ./app_sidebar_collapsible.py: href=dash.get_relative_path("/data"), ./app_sidebar_collapsible.py: href=dash.get_relative_path("/tokens"), ./app_sidebar_collapsible.py: href=dash.get_relative_path("/map"), ./app_sidebar_collapsible.py: href=dash.get_relative_path("/push_notification"), ./app_sidebar_collapsible.py: href=dash.get_relative_path("/settings"), ```
|
This fixes #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/admin/