Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove dependencies, upgrade the base image and remove unused auth methods #907

Merged

Conversation

shankari
Copy link
Contributor

Corresponding to #906

That was a hacky branch which we are now ready to remove
We have removed the branch, we are now removing the automatic build from the branch
This is a partial fix for e-mission/e-mission-docs#855
We currently only support token-based authentication, either using a token
generated on the phone (`skip`) or pre-generated (`token_list`).
Removing the google auth and openid authentication methods, and the python
package used for the auth to slim down our dependency profile

Testing done:
- Launched server with changes
- Logged in via the UI
…itch to jq

- Previously commented out dependencies were "deprecated"; remove them
- Comment out other lines that don't seem to be needed - e.g. editors; these
  are now deprecated and will be removed in the next edit
- switch to jq instead of sed to support more complex mongoDB URLs and be
  more consistent with the internal server build
- install wget in addition to curl so we don't need to use `apt-get update` in
  the internal repo; we should be able to remove it in the next iteration if we
  are not using it.

Testing done:
- Launched the container as part of a docker-compose
- Checked the logs and the server started up
- Tried to connect to the server using a browser, was redirected to the notfound URL
- Tried to connect to the server using the phone app, got a 403 error (since we hadn't loaded any data)
🔥 remove dependencies, upgrade the base image and remove unused auth methods
@shankari shankari merged commit 2e53774 into e-mission:gis-based-mode-detection Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant