Get confidenceThreshold from config file #780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Get confidenceThreshold from the trip object instead of using a hardcoded placeholder End-to-end testing: 1. Use server and client branches with only mode and purpose 2. Enable placeholder predictor 3 3. Use an expectations config that has a relaxed mode with a confidenceThreshold < 0.80 and an intensive mode with a confidence threshold >= 0.80 with a schedule beginning at 2015-07-22T16:00:00 local time 2. Reset pipeline; load and intake the shankari_2015-07-22 test_july_22 test dataset 4. Ensure on the client that the second most recent trip has all yellow labels and that the most recent trip has all red labels
shankari
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the confidenceThreshold from the server
confidenceThresholdfrom the trip object instead of using a hardcoded placeholderEnd-to-end testing:
confidenceThreshold< 0.80 and an intensive mode with aconfidenceThreshold>= 0.80 with a schedule beginning at2015-07-22T16:00:00local timeshankari_2015-07-22test_july_22test dataset