Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cordova-Android to 10.0.1 to prevent build issues with Android build-tools 31 #768

Closed
wants to merge 1 commit into from
Closed

Conversation

WilliamChan4
Copy link

@WilliamChan4 WilliamChan4 commented Aug 3, 2021

Update Cordova-Android to 10.0.1 to prevent build issues with Android build-tools 31

Replace phonegap-plugin-push with cordova-plugin-push to remove dependency on cordova-support-google-services causing build error with GradlePluginGoogleServicesEnabled.

phonegap/phonegap-plugin-push#2873
https://github.com/havesource/cordova-plugin-push/pull/8/files

… build-tools 31.

Replace phonegap-plugin-push with cordova-plugin-push to remove dependency on cordova-support-google-services causing build error with GradlePluginGoogleServicesEnabled
@shankari
Copy link
Contributor

shankari commented Aug 3, 2021

@WilliamChan4 alas, this looks like it didn't actually work.
I'm going to start with downgrading the tools on GHA so we can get this to work, and then we need more testing with the new cordova version before we upgrade.

@shankari
Copy link
Contributor

Closing this since I am not going to work on this right now.
Workaround committed in #779

@shankari shankari closed this Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants