Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent barcode scanner plugin from being invoked if it is already open #1186

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

JGreenlee
Copy link
Collaborator

@JGreenlee JGreenlee commented Oct 10, 2024

testing done:
On iPhone 6S, double-tapped "scan code" multiple trials and observed no errors. The scanner successfully opened on each trial

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 29.41%. Comparing base (03dd1f0) to head (d4986e9).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
www/js/onboarding/WelcomePage.tsx 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1186      +/-   ##
==========================================
- Coverage   29.44%   29.41%   -0.03%     
==========================================
  Files         122      122              
  Lines        4914     4919       +5     
  Branches     1124     1125       +1     
==========================================
  Hits         1447     1447              
- Misses       3465     3470       +5     
  Partials        2        2              
Flag Coverage Δ
unit 29.41% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
www/js/onboarding/WelcomePage.tsx 0.00% <0.00%> (ø)

testing done: double-tapped "scan code" multiple trials and observed no errors. The scanner successfully opened on each trial
@shankari shankari merged commit 66f61e0 into e-mission:master Oct 11, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tasks completed
Development

Successfully merging this pull request may close these issues.

2 participants