Pull out visualization code from the similarity detection #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is largely a direct copy of the existing `graph` function from `emission/analysis/modelling/tour_model/similarity.py` in https://github.com/e-mission/e-mission-server.git Minor modifications: - move the matplotlib imports out - create a figure (`fig = plt.figure()`) before the plot - return the figure so it is displayed properly - add a line indicating the cutoff point in the graph - change the color of the existing cutoff to be red - notice that it is not visible - add a line indicating the cutoff instead Also add the scaffolding to read and analyse data before generating the graph - read the data - create a similarity object - create the bins Note that this uses the newly refactored `calc_cutoff_bins` method so we can plot the graph *before* and after the uncommon trips are removed
shankari
added a commit
to shankari/e-mission-server
that referenced
this pull request
Jan 27, 2021
Pull out the visualization code so it can be run in a notebook New code is here: e-mission/e-mission-eval-private-data#14 Required a minor refactor since the prior call to graph was in the middle of `delete_bins` - after the cutoff and before the remove. We clearly don't want to generate graphs for this as part of a production system. So it is correct to remove the `graph()` call. To access the state of the object between the cutoff and the remove, we pull out the cutoff into a separate function
This was referenced Jan 27, 2021
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
Pull out the visualization code so it can be run in a notebook New code is here: e-mission/e-mission-eval-private-data#14 Required a minor refactor since the prior call to graph was in the middle of `delete_bins` - after the cutoff and before the remove. We clearly don't want to generate graphs for this as part of a production system. So it is correct to remove the `graph()` call. To access the state of the object between the cutoff and the remove, we pull out the cutoff into a separate function
humbleOldSage
pushed a commit
to humbleOldSage/e-mission-eval-private-data
that referenced
this pull request
Dec 1, 2023
This is largely a direct copy of the existing `graph` function from `emission/analysis/modelling/tour_model/similarity.py` in https://github.com/e-mission/e-mission-server.git Minor modifications: - move the matplotlib imports out - create a figure (`fig = plt.figure()`) before the plot - return the figure so it is displayed properly - add a line indicating the cutoff point in the graph - change the color of the existing cutoff to be red - notice that it is not visible - add a line indicating the cutoff instead Also add the scaffolding to read and analyse data before generating the graph - read the data - create a similarity object - create the bins Note that this uses the newly refactored `calc_cutoff_bins` method so we can plot the graph *before* and after the uncommon trips are removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely a direct copy of the existing
graphfunction fromemission/analysis/modelling/tour_model/similarity.pyinhttps://github.com/e-mission/e-mission-server.git
Minor modifications:
fig = plt.figure()) before the plotAlso add the scaffolding to read and analyse data before generating the graph
Note that this uses the newly refactored
calc_cutoff_binsmethod so we canplot the graph before and after the uncommon trips are removed