Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to pip env for python installation #707

Merged
merged 29 commits into from
Jul 20, 2023
Merged

Move to pip env for python installation #707

merged 29 commits into from
Jul 20, 2023

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Jul 17, 2023 •
edited
Loading

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

No pip env used
Unblob and binwalk installed manually

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

switched to pip environment
unblob and binwalk now installed with apt-get

  • Other information:

See https://www.kali.org/blog/python-externally-managed/
See https://twitter.com/qkaiser/status/1668620910679699460?s=20

Note: We need to synchronise the merge of this PR with updating the docker image.
Note: A new installation is needed to setup everything correctly.

@m-1-k-3 m-1-k-3 added enhancement New feature or request docker docker related things Installation Installation issues labels Jul 17, 2023
@m-1-k-3 m-1-k-3 changed the title Pip env switch Move to pip env for python installation Jul 19, 2023
BenediktMKuehne
BenediktMKuehne reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@BenediktMKuehne BenediktMKuehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are ✔️

docker-compose.yml Outdated Show resolved Hide resolved
m-1-k-3 and others added 2 commits July 20, 2023 15:38
@m-1-k-3 m-1-k-3 merged commit b5d2f96 into e-m-b-a:master Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenediktMKuehne BenediktMKuehne BenediktMKuehne approved these changes

Assignees
No one assigned
Labels
docker docker related things enhancement New feature or request Installation Installation issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-1-k-3 @BenediktMKuehne