exit on pre-checking selection #1382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenediktMKuehne
requested changes
Nov 18, 2024
emba
Outdated
| @@ -189,6 +189,15 @@ run_modules() | |||
| SELECT_MODULES+=("S24") | |||
| fi | |||
|
|
|||
| # manual selection of pre-checking modules not supported. EMBA is doint this for you! | |||
There was a problem hiding this comment.
Mixture of doing and don't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
EMBA does not support manual pre-checker selection. If a user is trying to select pre-checking modules via -m parameter EMBA behaves weird. (see #1373 )
warn and exit - closes #1373
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: