Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Validate by Spec Version Number #26

Open
e-lo opened this issue Jun 9, 2023 · 0 comments · Fixed by #30
Open

🚀 Validate by Spec Version Number #26

e-lo opened this issue Jun 9, 2023 · 0 comments · Fixed by #30
Labels
🚀 feature New feature or request

Comments

@e-lo
Copy link
Owner

e-lo commented Jun 9, 2023

I'd like to be able to validate my data based on a specific version of the GMNS spec, including the latest.

Implementation Idea

Pull spec by its tagged release version or main HEAD (latest) to validate to.

Dependent on #25
@e-lo e-lo added the 🚀 feature New feature or request label Jun 9, 2023
@e-lo e-lo changed the title Validate by Spec Version Number 🚀 Validate by Spec Version Number Jun 9, 2023
@e-lo e-lo mentioned this issue Jun 13, 2023
Merged
9 tasks
e-lo added a commit that referenced this issue Jun 14, 2023
@e-lo
Validate against a remote schema and by version tag.
2918316 
Provides the functionality to validate against a remote schema hosted on github by github reference (e.g. master HEAD, version tag, etc.). It also pulls out a "spec" as a class object to make it easier to pass around and abstract the differences between getting a spec from Github vs Local files.

This PR also:

- formats code per pre-commit
- refactors apply_schema_to_df into smaller functions
- updates errors and warning to be more helpful (pointing to files, etc)
- adds tests for field constraints in constraint_tests.py
- adds assert statements to basic_tests.py

Closes #25 
Closes #26

NOTE: Tests failing due to zephyr-data-specs/GMNS#70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🚀 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Leverage remote schemas by version number; test constraints e-lo/GMNSpy
1 participant
@e-lo