Hamlet TextMate rule improvements #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixphix
force-pushed
the
conditional-attribute-highlight
branch
from
0f12074
to
ffdb8d5
Compare
waddlaw
approved these changes
Apr 18, 2021
|
@bi-functor That's awesome! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! This pull request addresses several bugs in the Hamlet syntax highlighting.
Let me begin with a side-by-side comparison of the syntax highlighting with current master and with my changes.
Current master:
bi-functor/conditional-attribute-highlight:
The most noticeable change is on line 6. Conditional attributes no longer highlight the entire row: in between the colons is formatted as interpolated code, and only the attribute following the second colon is highlighted as such.
Attribute properties in string format, such as
"button"on line 13, are highlighted in a separate colour as well. They permit interpolation within themselves as well as evidenced on line 6.Tag names are now specially highlighted, to distinguish them from attributes.
Also, CSS class selectors now highlight the dashes between words, not just the underscores.
Some scopes have been renamed according to the Sublime Text Scope Naming guide: mostly replacing
embeddedwithinterpolationand making sure that interpolated Haskell source code has the proper name (source.haskell.embedded).